Messages in this thread | | | Date | Fri, 3 Jun 2022 11:36:57 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v4 00/12] perf c2c: Support display for Arm64 |
| |
Hi Ian,
On Thu, Jun 02, 2022 at 09:59:29AM -0700, Ian Rogers wrote:
[...]
> This is great Leo! I've not been able to test the changes but I didn't > have any coding comments (happy to give an Acked-by). Do you think we > can add a test for this? The test can skip when c2c isn't supported.
It would be great if recieve your ACK tags :)
Yeah, agree that it's good thing to add test for perf c2c. Just note, after rough thinkіng, seems to me the right thing to do is to add a testing shell script in the folder tests/shell and use a tiny multi-threading program for accessing the share cache line from different nodes (or rollback to different CPUs).
I would like to use a separate patch for adding the test case, this would be easier for upstreaming current patch set.
Please let me know if this is fine for you or not. Thanks for reviewing and suggestions!
Leo
| |