Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 19 Jun 2022 13:12:09 +0200 | Subject | Re: [PATCH v3 00/16] Add support for AXP192 PMIC |
| |
On Sun, Jun 19, 2022 at 1:08 PM Jonathan Cameron <jic23@kernel.org> wrote: > On Sun, 19 Jun 2022 00:43:07 +0200 > Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Saturday, June 18, 2022, Aidan MacDonald <aidanmacdonald.0x0@gmail.com> > > wrote: > > > > > Changes in v3: > > > > > > * Update pinctrl driver to address Andy Shevchenko's review comments > > > from v1, and fix a few other > > > > I believe I gave more comments than just against pin control driver. Even > > though, some comments are still not addressed in the series, including pin > > control. Am I mistaken? > > Hi Andy, > > Maybe, it's a question of clarity/misunderstanding? You had some 'global' comments > at the end of the pinctrl review. Perhaps not clear enough you meant > they should apply to the rest of the patch series (and more generally to > the driver being modified I think).
Yeah, I think that is. I don't remember if we have somewhere a documentation on how to respond to the review comments, in which the point of addressing comment everywhere in the series, and not only in the place(s) where it was given.
-- With Best Regards, Andy Shevchenko
| |