Messages in this thread | | | From | Arnd Bergmann <> | Date | Sun, 19 Jun 2022 11:49:31 +0200 | Subject | Re: [net-next PATCH] net: ethernet: stmmac: remove select QCOM_SOCINFO and make it optional |
| |
On Fri, Jun 17, 2022 at 12:15 AM Christian Marangi <ansuelsmth@gmail.com> wrote: > > QCOM_SOCINFO depends on QCOM_SMEM but is not selected, this cause some > problems with QCOM_SOCINFO getting selected with the dependency of > QCOM_SMEM not met. > To fix this remove the select in Kconfig and add additional info in the > DWMAC_IPQ806X config description. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 9ec092d2feb6 ("net: ethernet: stmmac: add missing sgmii configure for ipq806x") > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig > index c4bca16dae57..31ff35174034 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > @@ -83,7 +83,6 @@ config DWMAC_IPQ806X > default ARCH_QCOM > depends on OF && (ARCH_QCOM || COMPILE_TEST) > select MFD_SYSCON > - select QCOM_SOCINFO > help > Support for QCA IPQ806X DWMAC Ethernet. > > @@ -92,6 +91,9 @@ config DWMAC_IPQ806X > acceleration features available on this SoC. Network devices > will behave like standard non-accelerated ethernet interfaces. > > + Select the QCOM_SOCINFO config flag to enable specific dwmac > + fixup based on the ipq806x SoC revision.
I think the correct way would have been to use
depends on QCOM_SOCINFO || COMPILE_TEST
here.
Arnd
| |