Messages in this thread Patch in this message | | | From | onenowy <> | Subject | Re: 2 second nvme initialization delay regression in 5.18 [Was: Re: [bug report]nvme0: Admin Cmd(0x6), I/O Error (sct 0x0 / sc 0x2) MORE DNR observed during blktests] | Date | Mon, 20 Jun 2022 12:36:27 +0900 |
| |
> I don't think we can wait for 5.20 - the "offending" commit is in > 5.19-rc and -stable. So I'll plan to prepare a patch based on the model > number for now, still hoping we can come up with something better > eventually.
Hi , Some samsung SSD for OEM also have the identical PCI-ids and are affected by this quirk. But they have different subsystem-ids.
For example,
model number: MZQLB1T9HAJR-00V3 for lenovo vendor: 144d device: a808 subvendor: 1d49 subdevice: 403b
model number: MZVLB256HBHQ-00000 vendor: 144d device: a808 subvendor: 144d subdevice: a801
Addtition of subsystem-ids of X5 to pci_device_id(as below) may solve this problem.
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 17aeb7d5c48522..92fd3b1d88fc95 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3475,7 +3475,7 @@ static const struct pci_device_id nvme_id_table[] = { NVME_QUIRK_128_BYTES_SQES | NVME_QUIRK_SHARED_TAGS | NVME_QUIRK_SKIP_CID_GEN }, - { PCI_DEVICE(0x144d, 0xa808), /* Samsung X5 */ + { PCI_DEVICE_SUB(0x144d, 0xa808, {X5 subvendor?}, {X5 subdevice?}), /* Samsung X5 */ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY| NVME_QUIRK_NO_DEEPEST_PS | NVME_QUIRK_IGNORE_DEV_SUBNQN, },
But I don't know X5's subsystem ids, Can someone provide subsystem-ids of X5?
| |