lkml.org 
[lkml]   [2022]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] sbus: char: Fix refcount leak bug in openrom.c
Date
In opiocgetnext(), we need a of_node_put() to keep refcount balance
for device_node pointer returned by of_find_node_by_phandle() or
of_find_node_by_path().

Signed-off-by: Liang He <windhl@126.com>
---
drivers/sbus/char/openprom.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/sbus/char/openprom.c b/drivers/sbus/char/openprom.c
index 30b9751aad30..701978db0f0f 100644
--- a/drivers/sbus/char/openprom.c
+++ b/drivers/sbus/char/openprom.c
@@ -518,6 +518,7 @@ static int opiocgetnext(unsigned int cmd, void __user *argp)
}
if (dp)
nd = dp->phandle;
+ of_node_put(dp);
if (copy_to_user(argp, &nd, sizeof(phandle)))
return -EFAULT;

--
2.25.1
\
 
 \ /
  Last update: 2022-06-18 09:38    [W:0.022 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site