Messages in this thread Patch in this message | | | From | Christophe Leroy <> | Subject | Re: [PATCH] powerpc: kernel: Change the order of of_node_put() | Date | Sat, 18 Jun 2022 07:13:13 +0000 |
| |
Le 17/06/2022 à 13:26, Liang He a écrit : > In add_pcspkr(), it is better to call of_node_put() after the > 'if(!np)' check.
Why is it better ?
/** * of_node_put() - Decrement refcount of a node * @node: Node to dec refcount, NULL is supported to simplify writing of * callers */ void of_node_put(struct device_node *node) { if (node) kobject_put(&node->kobj); } EXPORT_SYMBOL(of_node_put);
Christophe
> > Signed-off-by: Liang He <windhl@126.com> > --- > arch/powerpc/kernel/setup-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c > index eb0077b302e2..761817d1f4db 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -563,9 +563,9 @@ static __init int add_pcspkr(void) > int ret; > > np = of_find_compatible_node(NULL, NULL, "pnpPNP,100"); > - of_node_put(np); > if (!np) > return -ENODEV; > + of_node_put(np); > > pd = platform_device_alloc("pcspkr", -1); > if (!pd)
| |