lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not present
Hi Mike,

I love your patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on linus/master v5.19-rc2 next-20220617]
[cannot apply to arm64/for-next/core arm/for-next kvmarm/next xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20220618/202206180021.rcc4B1by-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/4c647687607f10fece04967b8180c0dadaf765e6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726
git checkout 4c647687607f10fece04967b8180c0dadaf765e6
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

mm/hugetlb.c: In function 'hugetlb_mask_last_page':
>> mm/hugetlb.c:6901:9: error: duplicate case value
6901 | case PUD_SIZE:
| ^~~~
mm/hugetlb.c:6899:9: note: previously used here
6899 | case P4D_SIZE:
| ^~~~


vim +6901 mm/hugetlb.c

6886
6887 /*
6888 * Return a mask that can be used to update an address to the last huge
6889 * page in a page table page mapping size. Used to skip non-present
6890 * page table entries when linearly scanning address ranges. Architectures
6891 * with unique huge page to page table relationships can define their own
6892 * version of this routine.
6893 */
6894 unsigned long hugetlb_mask_last_page(struct hstate *h)
6895 {
6896 unsigned long hp_size = huge_page_size(h);
6897
6898 switch (hp_size) {
6899 case P4D_SIZE:
6900 return PGDIR_SIZE - P4D_SIZE;
> 6901 case PUD_SIZE:
6902 return P4D_SIZE - PUD_SIZE;
6903 case PMD_SIZE:
6904 return PUD_SIZE - PMD_SIZE;
6905 default:
6906 break; /* Should never happen */
6907 }
6908
6909 return ~(0UL);
6910 }
6911

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-06-17 19:25    [W:0.120 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site