lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] Remove unnecessary variable assignment in agp_generic_create_gatt_table()
Date
Remove unnecessary variable assignments in the function
agp_generic_create_gatt_table(). This fixes the clang scan warnings:

warning: Value stored to 'page_order' is never read [deadcode.DeadStores]
page_order = num_entries = 0;

warning: Although the value stored to 'num_entries' is used in the
enclosing expression, the value is never actually read from 'num_entries'
[deadcode.DeadStores]

Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
---
changes in v2:
1. Initialize the variables where they are declared.

drivers/char/agp/generic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index 3ffbb1c80c5c..7fe72c07647d 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -851,8 +851,8 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)
{
char *table;
char *table_end;
- int page_order;
- int num_entries;
+ int page_order = 0;
+ int num_entries = 0;
int i;
void *temp;
struct page *page;
@@ -864,7 +864,6 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)
table = NULL;
i = bridge->aperture_size_idx;
temp = bridge->current_size;
- page_order = num_entries = 0;

if (bridge->driver->size_type != FIXED_APER_SIZE) {
do {
--
2.34.1
\
 
 \ /
  Last update: 2022-06-17 19:20    [W:0.247 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site