Messages in this thread | | | Subject | Re: [PATCH] arm: mach-imx: Fix refcount leak bug in src | From | Philipp Zabel <> | Date | Fri, 17 Jun 2022 17:39:43 +0200 |
| |
Hi,
On Fr, 2022-06-17 at 20:12 +0800, Liang He wrote: > In imx7_src_init(), of_find_compatible_node() will return a node > pointer with refcount incremented. We should use of_node_put() when > it is not used anymore. > > Signed-off-by: Liang He <windhl@126.com> > --- > arch/arm/mach-imx/src.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-imx/src.c b/arch/arm/mach-imx/src.c > index 59a8e8cc4469..fff2776f9180 100644 > --- a/arch/arm/mach-imx/src.c > +++ b/arch/arm/mach-imx/src.c > @@ -195,6 +195,7 @@ void __init imx7_src_init(void) > return; > > > > > src_base = of_iomap(np, 0); > + of_node_put(np);
Thank you for the patch. There is another instance of this pattern a few lines above, in imx_src_init().
regards Philipp
| |