lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] powerpc: sysdev: Fix refcount leak bug in mpic_msgr
    Date
    In mpic_msgr_number_of_blocks() and mpic_msgr_block_number(),
    of_find_node_by_name() will return a node pointer with refcount
    incremented. We should use of_node_put() when it is not used
    anymore.

    Signed-off-by: Liang He <windhl@126.com>
    ---
    arch/powerpc/sysdev/mpic_msgr.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/sysdev/mpic_msgr.c b/arch/powerpc/sysdev/mpic_msgr.c
    index 698fefaaa6dd..c2a235d9eb09 100644
    --- a/arch/powerpc/sysdev/mpic_msgr.c
    +++ b/arch/powerpc/sysdev/mpic_msgr.c
    @@ -122,6 +122,7 @@ static unsigned int mpic_msgr_number_of_blocks(void)
    count += 1;
    }
    }
    + of_node_put(aliases);

    return count;
    }
    @@ -150,6 +151,7 @@ static int mpic_msgr_block_number(struct device_node *node)
    if (node == of_find_node_by_path(prop->value))
    break;
    }
    + of_node_put(aliases);

    return index == number_of_blocks ? -1 : index;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-17 17:19    [W:5.254 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site