Messages in this thread | | | Date | Fri, 17 Jun 2022 08:02:26 +0200 | Subject | Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32 | From | Michal Simek <> |
| |
On 6/17/22 07:19, Srinivas Neeli wrote: > In five different instances the return value of "of_property_read_u32" > API was neither captured nor checked. > > Fixed it by capturing the return value and then checking for any error. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> > Addresses-Coverity: "check_return" > --- > drivers/gpio/gpio-xilinx.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c > index b6d3a57e27ed..268c7b0e481d 100644 > --- a/drivers/gpio/gpio-xilinx.c > +++ b/drivers/gpio/gpio-xilinx.c > @@ -570,7 +570,8 @@ static int xgpio_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, chip); > > /* First, check if the device is dual-channel */ > - of_property_read_u32(np, "xlnx,is-dual", &is_dual); > + if (of_property_read_u32(np, "xlnx,is-dual", &is_dual)) > + is_dual = 0;
All these values are initialized already. Isn't it enough to just ignore return value like this to make coverity happy?
(void)of_property_read_u32(np, "xlnx,is-dual", &is_dual)
Thanks, Michal
| |