Messages in this thread | | | Date | Fri, 17 Jun 2022 16:16:33 +0300 | From | Ido Schimmel <> | Subject | Re: [PATCH net] ethtool: Fix get module eeprom fallback |
| |
On Thu, Jun 16, 2022 at 06:08:55PM +0200, Ivan Vecera wrote: > Function fallback_set_params() checks if the module type returned > by a driver is ETH_MODULE_SFF_8079 and in this case it assumes > that buffer returns a concatenated content of page A0h and A2h. > The check is wrong because the correct type is ETH_MODULE_SFF_8472. > > Fixes: 96d971e307cc ("ethtool: Add fallback to get_module_eeprom from netlink command") > Cc: Ido Schimmel <idosch@nvidia.com> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
All the drivers that report ETH_MODULE_SFF_8079 also report a length of ETH_MODULE_SFF_8079_LEN, which means they are only accessing I2C address 0x50.
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
| |