lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region
Matt,

please cc linux-arm-kernel mailing list as well

On 03:51-20220616, Matt Ranostay wrote:
> GICD region was overlapping with GICR causing the latter to not map
> successfully, and in turn the gic-v3 driver would fail to initialize.
>
> This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
> replaced of_iomap() calls with of_io_request_and_map() that internally
> called request_mem_region().
>
> Respective console output before this patchset:
>
> [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0
>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Nishanth Menon <nm@ti.com>
> Signed-off-by: Matt Ranostay <mranostay@ti.com>

Thank you for root causing the bug, BUT, please add a Fixes: tag as
well. this needs to go into stable as well.

> ---
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index be7f39299894..19966f72c5b3 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -33,7 +33,7 @@ gic500: interrupt-controller@1800000 {
> ranges;
> #interrupt-cells = <3>;
> interrupt-controller;
> - reg = <0x00 0x01800000 0x00 0x200000>, /* GICD */
> + reg = <0x00 0x01800000 0x00 0x100000>, /* GICD */
> <0x00 0x01900000 0x00 0x100000>, /* GICR */
> <0x00 0x6f000000 0x00 0x2000>, /* GICC */
> <0x00 0x6f010000 0x00 0x1000>, /* GICH */
> --
> 2.36.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

\
 
 \ /
  Last update: 2022-06-17 15:05    [W:0.258 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site