lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 16/40] arm64: dts: mediatek: mt7622-bananapi-bpi-r64: align led node names with dtschema
From


On 16/06/2022 02:53, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern
> with 'led'. Use generic color properties instead of the node name.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied, thanks!

> ---
> arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index c2311733d2de..7d1ecf72a6c3 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -8,6 +8,7 @@
> /dts-v1/;
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>
> #include "mt7622.dtsi"
> #include "mt6380.dtsi"
> @@ -56,14 +57,16 @@ wps-key {
> leds {
> compatible = "gpio-leds";
>
> - green {
> + led-0 {
> label = "bpi-r64:pio:green";
> + color = <LED_COLOR_ID_GREEN>;
> gpios = <&pio 89 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - red {
> + led-1 {
> label = "bpi-r64:pio:red";
> + color = <LED_COLOR_ID_RED>;
> gpios = <&pio 88 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };

\
 
 \ /
  Last update: 2022-06-17 12:44    [W:1.515 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site