lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: ov7251: add missing clk_disable_unprepare() on error in ov7251_set_power_on()
On Fri, Jun 17, 2022 at 09:39:43AM +0800, Yang Yingliang wrote:
> Add the missing clk_disable_unprepare() before return
> from ov7251_set_power_on() in the error handling case.

...

> if (ret < 0) {
> dev_err(ov7251->dev, "error during global init\n");
> + clk_disable_unprepare(ov7251->xclk);
> ov7251_regulators_disable(ov7251);

Logically it should go here. Please, read a code above this check.

> return ret;
> }

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-06-17 12:20    [W:0.059 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site