Messages in this thread | | | Date | Fri, 17 Jun 2022 09:31:13 +0200 | Subject | Re: [PATCH] soc: amlogic: Fix refcount leak in meson-secure-pwrc.c | From | Neil Armstrong <> |
| |
On 16/06/2022 16:49, Liang He wrote: > In meson_secure_pwrc_probe(), there is a refcount leak in one fail > path. > > Signed-off-by: Liang He <windhl@126.com> Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > --- > drivers/soc/amlogic/meson-secure-pwrc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c > index a10a417a87db..e93518763526 100644 > --- a/drivers/soc/amlogic/meson-secure-pwrc.c > +++ b/drivers/soc/amlogic/meson-secure-pwrc.c > @@ -152,8 +152,10 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev) > } > > pwrc = devm_kzalloc(&pdev->dev, sizeof(*pwrc), GFP_KERNEL); > - if (!pwrc) > + if (!pwrc) { > + of_node_put(sm_np); > return -ENOMEM; > + } > > pwrc->fw = meson_sm_get(sm_np); > of_node_put(sm_np);
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
| |