lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/3] tracing: eprobe: remove duplicate is_good_name() operation
On Tue, 14 Jun 2022 09:04:56 +0800
Linyu Yuan <quic_linyyuan@quicinc.com> wrote:

> traceprobe_parse_event_name() already validate group and event name,
> there is no need to call is_good_name() after it.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
> v2: drop v1 change as it is NACK.
> add it to remove duplicate is_good_name().
> v3: move it as first patch.
> v4: no change
> v5: add Acked-by tag
>
> kernel/trace/trace_eprobe.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
> index 7d44785..17d64e3 100644
> --- a/kernel/trace/trace_eprobe.c
> +++ b/kernel/trace/trace_eprobe.c
> @@ -878,16 +878,12 @@ static int __trace_eprobe_create(int argc, const char *argv[])
> sanitize_event_name(buf1);
> event = buf1;
> }
> - if (!is_good_name(event) || !is_good_name(group))
> - goto parse_error;
>

Tom replied that the above may be an issue. You ignored his response.

-- Steve


> sys_event = argv[1];
> ret = traceprobe_parse_event_name(&sys_event, &sys_name, buf2,
> sys_event - argv[1]);
> if (ret || !sys_name)
> goto parse_error;
> - if (!is_good_name(sys_event) || !is_good_name(sys_name))
> - goto parse_error;
>
> mutex_lock(&event_mutex);
> event_call = find_and_get_event(sys_name, sys_event);

\
 
 \ /
  Last update: 2022-06-18 03:50    [W:0.141 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site