lkml.org 
[lkml]   [2022]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dt-bindings: mmc: mtk-sd: Set clocks based on compatible
From
On 17/06/2022 16:01, Nícolas F. R. A. Prado wrote:
> The binding was describing a single clock list for all platforms, but
> that's not really suitable: mt2712 requires an extra 'bus_clk' on some
> of its controllers, while mt8192 requires four different extra clocks.
> The rest of the platforms can share the same 3 clocks, with the third
> being optional as it's not present on all platforms.
>
> Move the clock definitions inside if blocks that match on the
> compatibles. In practice this gets rid of dtbs_check warnings on mt8192,
> since the 'bus_clk' clock from mt2712 is no longer expected on this
> platform.
>
> Fixes: 59a23395d8aa ("dt-bindings: mmc: Add support for MT8192 SoC")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> .../devicetree/bindings/mmc/mtk-sd.yaml | 115 ++++++++++++------
> 1 file changed, 81 insertions(+), 34 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..ba48ff041299 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -10,9 +10,6 @@ maintainers:
> - Chaotian Jing <chaotian.jing@mediatek.com>
> - Wenbin Mei <wenbin.mei@mediatek.com>
>
> -allOf:
> - - $ref: mmc-controller.yaml#
> -
> properties:
> compatible:
> oneOf:
> @@ -48,28 +45,8 @@ properties:
> clocks:
> description:
> Should contain phandle for the clock feeding the MMC controller.
> - minItems: 2

Keep minItems and maxItems matching the widest constraints.

> - items:
> - - description: source clock (required).
> - - description: HCLK which used for host (required).
> - - description: independent source clock gate (required for MT2712).
> - - description: bus clock used for internal register access (required for MT2712 MSDC0/3).
> - - description: msdc subsys clock gate (required for MT8192).
> - - description: peripheral bus clock gate (required for MT8192).
> - - description: AXI bus clock gate (required for MT8192).
> - - description: AHB bus clock gate (required for MT8192).
> -
> - clock-names:
> - minItems: 2

ditto

>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-18 03:21    [W:0.035 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site