Messages in this thread | | | Date | Thu, 16 Jun 2022 18:44:53 +0000 | From | oliver.upton@linux ... | Subject | Re: [PATCH] selftests: KVM: Handle compiler optimizations in ucall |
| |
June 16, 2022 11:48 AM, "David Laight" <David.Laight@aculab.com> wrote: > No wonder I was confused. > It's not surprising the compiler optimises it all away. > > It doesn't seem right to be 'abusing' WRITE_ONCE() here. > Just adding barrier() should be enough and much more descriptive.
I had the same thought, although I do not believe barrier() is sufficient on its own. barrier_data() with a pointer to uc passed through is required to keep clang from eliminating the dead store.
-- Thanks, Oliver
| |