Messages in this thread | | | Date | Thu, 16 Jun 2022 17:33:56 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v1 1/1] net: phy: at803x: fix NULL pointer dereference on AR9331 PHY |
| |
On Thu, Jun 16, 2022 at 03:38:15PM +0200, Andrew Lunn wrote: > On Thu, Jun 16, 2022 at 01:31:05PM +0200, Oleksij Rempel wrote: > > Latest kernel will explode on the PHY interrupt config, since it depends > > now on allocated priv. So, run probe to allocate priv to fix it. > > > > Fixes: 3265f4218878 ("net: phy: at803x: add fiber support") > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > drivers/net/phy/at803x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > index 6a467e7817a6..b72a807f2e03 100644 > > --- a/drivers/net/phy/at803x.c > > +++ b/drivers/net/phy/at803x.c > > @@ -2072,6 +2072,8 @@ static struct phy_driver at803x_driver[] = { > > /* ATHEROS AR9331 */ > > PHY_ID_MATCH_EXACT(ATH9331_PHY_ID), > > .name = "Qualcomm Atheros AR9331 built-in PHY", > > + .probe = at803x_probe, > > + .remove = at803x_remove, > > .suspend = at803x_suspend, > > .resume = at803x_resume, > > .flags = PHY_POLL_CABLE_TEST, > > Is the same change needed for some of the other PHYs? QCA8081? > QCA9561?
Yes, good point.
Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |