lkml.org 
[lkml]   [2022]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 10/13] dm-table: use bdev_is_zone_start helper in device_area_is_invalid()
From
drivers/md/dm-table.c
>> +++ b/drivers/md/dm-table.c
>> @@ -251,7 +251,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>> if (bdev_is_zoned(bdev)) {
>> unsigned int zone_sectors = bdev_zone_sectors(bdev);
>>
>> - if (start & (zone_sectors - 1)) {
>> + if (blk_queue_is_zone_start(bdev_get_queue(bdev), start)) {
>
> This is wrong. And you are changing this to the correct test in the next
> patch.
>
Yeah, I think I made a mistake while committing it. The next patch
should only have the removing po2 condition check and these changes
should have been only in this patch. I will fix it up!
>> DMWARN("%s: start=%llu not aligned to h/w zone size %u of %pg",
>> dm_device_name(ti->table->md),
>> (unsigned long long)start,
>> @@ -268,7 +268,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>> * devices do not end up with a smaller zone in the middle of
>> * the sector range.
>> */
>> - if (len & (zone_sectors - 1)) {
>> + if (blk_queue_is_zone_start(bdev_get_queue(bdev), len)) {
>> DMWARN("%s: len=%llu not aligned to h/w zone size %u of %pg",
>> dm_device_name(ti->table->md),
>> (unsigned long long)len,
>
>

\
 
 \ /
  Last update: 2022-06-16 11:56    [W:0.903 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site