Messages in this thread | | | Date | Thu, 16 Jun 2022 11:00:52 +0200 | From | Jan Kara <> | Subject | Re: [PATCH] init: Initialize noop_backing_dev_info early |
| |
On Wed 15-06-22 23:08:22, Christoph Hellwig wrote: > On Wed, Jun 15, 2022 at 11:48:15PM +0200, Jan Kara wrote: > > +extern int bdi_init(struct backing_dev_info *bdi); > > No need for the extern.
Yes, fixed up.
> Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for review!
> And this remind me that I really want to kill noop_backing_dev_info > and just use a NULL bdi for this case eventually..
Yes, I'm just not sure whether the checks for bdi / wb being NULL in lots of places will not be too annoying... But maybe you'll be able to come up with some wrappers that will make things bearable.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |