Messages in this thread | | | Date | Thu, 16 Jun 2022 14:25:14 +0700 | Subject | Re: [PATCH v8 1/3] ipmi: ssif_bmc: Add SSIF BMC driver | From | Quan Nguyen <> |
| |
On 15/06/2022 23:06, Randy Dunlap wrote: > > > On 6/15/22 02:02, Quan Nguyen wrote: >> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig >> index b061e6b513ed..18a89093d64e 100644 >> --- a/drivers/char/ipmi/Kconfig >> +++ b/drivers/char/ipmi/Kconfig >> @@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BMC >> found on Aspeed SOCs (AST2400 and AST2500). The driver >> implements the BMC side of the BT interface. >> >> +config SSIF_IPMI_BMC >> + tristate "SSIF IPMI BMC driver" >> + select I2C > > No. That should be: > depends on I2C > > We don't select an entire subsystem just to satisfy one driver. > >> + select I2C_SLAVE >> + help >> + This enables the IPMI SMBus system interface (SSIF) at the >> + management (BMC) side. >> + >> + The driver implements the BMC side of the SMBus system >> + interface (SSIF). >> + > > Thanks.
Thanks Randy, it should be change to "depends on I2C && I2C_SLAVE"
Thanks, - Quan
| |