lkml.org 
[lkml]   [2022]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] soc: sifive: (sifive_l2_cache) Add missing of_node_put()
Date
On 16/06/2022 06:54, Liang He wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> At 2022-06-16 12:49:15, "Liang He" <windhl@126.com> wrote:
>> In sifive_l2_init(), of_find_matching_node() will return a node pointer
>> with refcount incremented. We should use of_node_put() in each fail path
>> or when it is not used anymore.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>
>
> Sorry, please ignore this version as it still has a bug. I will have a strict check and compile the code before my next commit.

While you're at it - drop the Reported-by too.
You only need to include that if LKP found a problem with
a patch that's been applied already. If it's on something
in progress, just fix what it pointed out & resend.

Thanks,
Conor.

\
 
 \ /
  Last update: 2022-06-16 08:28    [W:0.085 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site