lkml.org 
[lkml]   [2022]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 06/15] dt-bindings: mfd: Add Mediatek MT6370
From
On 13/06/2022 04:11, ChiaEn Wu wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add Mediatek MT6370 binding documentation.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> .../bindings/mfd/mediatek,mt6370.yaml | 279 ++++++++++++++++++
> .../dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 ++
> 2 files changed, 297 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
>
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
> new file mode 100644
> index 000000000000..6c2639e81e50
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
> @@ -0,0 +1,279 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mediatek,mt6370.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6370 SubPMIC
> +
> +maintainers:
> + - ChiYuan Huang <cy_huang@richtek.com>
> +
> +description: |
> + MT6370 is a highly-integrated smart power management IC, which includes a
> + single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
> + Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
> + driver, a backlight WLED driver, a display bias driver and a general LDO for
> + portable devices.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370
> +
> + reg:
> + maxItems: 1
> +
> + wakeup-source: true
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 1
> +
> + adc:
> + type: object
> + description: |
> + Provides 9 channels for system monitoring, including vbusdiv5, vbusdiv2,
> + vbat, vsys, chg_vddp, ts_bat, ibus, ibat, and temp_jc.
> +
> + properties:
> + compatible:
> + const: mediatek,mt6370-adc
> +
> + "#io-channel-cells":
> + const: 1
> +
> + required:
> + - compatible
> + - '#io-channel-cells'

Decide in your entire patchset whether you use ' or ". Don't mix.

Since you did not test your bindings, I am not reviewing it. First, test
them. No need for me to do the job of a automated tool, right?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-16 23:16    [W:0.689 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site