lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/4] leds: class: simplify the implementation of devm_of_led_get()
On Wed, Jun 15, 2022 at 5:49 PM Jean-Jacques Hiblot
<jjhiblot@traphandler.com> wrote:
>
> Use the devm_add_action_or_reset() helper.

...

> @@ -20,8 +20,10 @@
> #include <linux/timer.h>
> #include <uapi/linux/uleds.h>
> #include <linux/of.h>
> +#include <linux/acpi.h>
> #include "leds.h"
>
> +
> static struct class *leds_class;
>
> static ssize_t brightness_show(struct device *dev,

Stray changes.

...

> + led_put((struct led_classdev *) cdev);

Casting from/to void * is redundant.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-06-15 17:54    [W:0.197 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site