Messages in this thread | | | From | Alexander Lobakin <> | Subject | Re: [PATCH v2 0/6] bitops: let optimize out non-atomic bitops on compile-time constants | Date | Wed, 15 Jun 2022 16:17:32 +0200 |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Mon, 13 Jun 2022 17:22:30 +0200
> Hi Olek,
Hi!
> > On Mon, Jun 13, 2022 at 4:28 PM Alexander Lobakin > <alexandr.lobakin@intel.com> wrote: > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > On Fri, Jun 10, 2022 at 1:35 PM Alexander Lobakin > > > <alexandr.lobakin@intel.com> wrote: > > > On m68k, using gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04), this > > > blows up immediately with: > > > > Yeah I saw the kernel bot report already, sorry for that >_< Fixed > > in v3 already, will send in 1-2 days. > > Is it simple to fix? > I might be able to give the fixed v2 a try before that. > Thanks!
Oh, sorry for the late reply, was busy with stuff. It's linear, there are (after applying the series) some static inlines in arch/m68k/include/asm/bitops.h (those which were converted from macros in patch 3/6), 7 ops in total, you just need to create definitions with 'arch_' prefix for each of them, e.g.
#define arch_test_bit test_bit #define arch___set_bit __set_bit // will be ___set_bit after 5/6
etc. Hope I explained it clear-ish :)
> > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Thanks, Olek
| |