Messages in this thread Patch in this message | | | From | Liang He <> | Subject | [PATCH] drivers: edac: Add missing of_node_put() in altera_edac.c | Date | Wed, 15 Jun 2022 21:34:13 +0800 |
| |
In altr_portb_setup(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com> --- drivers/edac/altera_edac.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index e7e8e624a436..f035d131751c 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1528,7 +1528,8 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) edac_printk(KERN_ERR, EDAC_DEVICE, "%s: Unable to allocate PortB EDAC device\n", ecc_name); - return -ENOMEM; + rc = -ENOMEM; + goto out_put; } /* Initialize the PortB EDAC device structure from PortA structure */ @@ -1536,7 +1537,10 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) *altdev = *device; if (!devres_open_group(&altdev->ddev, altr_portb_setup, GFP_KERNEL)) - return -ENOMEM; + { + rc = -ENOMEM; + goto out_put; + } /* Update PortB specific values */ altdev->edac_dev_name = ecc_name; @@ -1605,6 +1609,9 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) rc = -ENOMEM; goto err_release_group_1; } + + of_node_put(np); + altr_create_edacdev_dbgfs(dci, prv); list_add(&altdev->next, &altdev->edac->a10_ecc_devices); @@ -1618,6 +1625,8 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) devres_release_group(&altdev->ddev, altr_portb_setup); edac_printk(KERN_ERR, EDAC_DEVICE, "%s:Error setting up EDAC device: %d\n", ecc_name, rc); +out_put: + of_node_put(np); return rc; } -- 2.25.1
| |