lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] RFC: torture: add pr_flush to flush the results to console
On Wed, Jun 15, 2022 at 08:37:33AM +0800, zhouzhouyi@gmail.com wrote:
> From: Zhouyi Zhou <zhouzhouyi@gmail.com>
>
> currently tools/testing/selftests/rcutorture/bin/torture.sh reports
> false positve because of kthread printing.
>
> Commit "printk: add functions to prefer direct printing" (2bb2b7b57f812)
> have added functions to prefer direct printing activated for the primary
> import messages.
>
> Meanwhile adding printk_prefer_direct_enter/exit to
> torture_cleanup_begin/end still can't eliminate the false positives
> for a hundred percent.
>
> This patch add pr_flush to torture_cleanup_end because the latter
> is sleepable.
>
> Reported-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> Tested-by: Zhouyi Zhou <zhouzhouyi@gmail.com>

Just the one Signed-off-by suffices. ;-)

> ---
> kernel/torture.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/torture.c b/kernel/torture.c
> index 789aeb0e1159..b51e42463a67 100644
> --- a/kernel/torture.c
> +++ b/kernel/torture.c
> @@ -878,6 +878,7 @@ void torture_cleanup_end(void)
> mutex_lock(&fullstop_mutex);
> torture_type = NULL;
> mutex_unlock(&fullstop_mutex);
> + pr_flush(1000, true);

But in this case, the kernel keeps on running, correct? So won't the
output appear over time? All of printk()'s kthreads are still running
after all.

Or do you have a use case that requires that the output appear sooner
than it does? If so, please let me know what that is.

Thanx, Paul

> }
> EXPORT_SYMBOL_GPL(torture_cleanup_end);
>
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2022-06-15 07:17    [W:0.074 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site