Messages in this thread | | | From | Jiri Olsa <> | Subject | [PATCHv3 bpf 0/4] bpf: Fix cookie values for kprobe multi | Date | Wed, 15 Jun 2022 13:21:14 +0200 |
| |
hi, there's bug in kprobe_multi link that makes cookies misplaced when using symbols to attach. The reason is that we sort symbols by name but not adjacent cookie values. Current test did not find it because bpf_fentry_test* are already sorted by name.
v3 changes: - fixed kprobe_multi bench test to filter out invalid entries from available_filter_functions
v2 changes: - rebased on top of bpf/master - checking if cookies are defined later in swap function [Andrii] - added acks
thanks, jirka
--- Jiri Olsa (4): selftests/bpf: Shuffle cookies symbols in kprobe multi test ftrace: Keep address offset in ftrace_lookup_symbols bpf: Force cookies array to follow symbols sorting selftest/bpf: Fix kprobe_multi bench test
kernel/trace/bpf_trace.c | 60 +++++++++++++++++++++++++++++++++++++++++++++--------------- kernel/trace/ftrace.c | 13 +++++++++++-- tools/testing/selftests/bpf/prog_tests/bpf_cookie.c | 78 +++++++++++++++++++++++++++++++++++++++--------------------------------------- tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 3 +++ tools/testing/selftests/bpf/progs/kprobe_multi.c | 24 ++++++++++++------------ 5 files changed, 110 insertions(+), 68 deletions(-)
| |