Messages in this thread | | | Date | Wed, 15 Jun 2022 13:13:16 +0200 | From | Claudio Imbrenda <> | Subject | Re: [PATCH v11 14/19] KVM: s390: pv: cleanup leftover protected VMs if needed |
| |
On Wed, 15 Jun 2022 12:57:39 +0200 Janosch Frank <frankja@linux.ibm.com> wrote:
[...]
> >> I think we should switch this patch and the next one and add this struct > >> to the next patch. The list work below makes more sense once the next > >> patch has been read. > > > > but the next patch will leave leftovers in some circumstances, and > > those won't be cleaned up without this patch. > > > > having this patch first means that when the next patch is applied, the > > leftovers are already taken care of > > Then I opt for squashing the patch. > > Without the next patch prepared_for_async_deinit will always be NULL and > this code is completely unneeded, no?
correct. I had split them to make them smaller and easier to review
I will squash them if you think it's better
> > > > >>> static void kvm_s390_clear_pv_state(struct kvm *kvm) > >>> { > >>> kvm->arch.pv.handle = 0; > >>> @@ -158,23 +171,88 @@ static int kvm_s390_pv_alloc_vm(struct kvm *kvm) > >>> return -ENOMEM; > >>> } > >>> > >> > >>> > >> > > >
| |