Messages in this thread | | | From | Kenneth Chan <> | Date | Wed, 15 Jun 2022 18:53:52 +0800 | Subject | Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys |
| |
I'm resending it due to reported spam. I forgot to turn off HTML formatting. My bad.
Thanks for the patches.
> From: Stefan Seyfried <seife+kernel@b1-systems.com> > > commit ed83c9171829 broke the hotkeys on my Toughbook CF-51. > I'm questioning the general validity of that commit, but as I only > have a single machine to test, add a module parameter to allow making > it work at runtime.
I can confirm that as soon as the hotkey_input option is enabled (at least on my aged CF-W5) it reports the ACPI event twice. Unfortunately it's the only machine I have for testing. Unless we have a bigger sample base, making it a module_param is a safe choice.
Otherwise the patches look good to me.
Reviewed-by: Kenneth Chan <kenneth.t.chan@gmail.com>
-- Kenneth
| |