Messages in this thread | | | Date | Wed, 15 Jun 2022 12:09:39 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support |
| |
> > > What about splitting this in two separate checks at the top level: > > > - one for regs (R-Car V3U vs. the world), and > > > - a second for interrupts (R-Car V3U+S4-8 vs. the world)? > > > > This task seems too much for my YAML-foo :( I couldn't get it to work. > > Can we leave it as-is for now? > > You just need an allOf with two if statements, cfr. e.g. > Documentation/devicetree/bindings/media/renesas,vin.yaml?
First, I don't think the negative logic is as bad here because there is no 'else' block which is far away. Second, I think we need a 'not' anyhow because the condition is: 'if not r8a779f0 then required interrupts'
Third, I still think we can fix it incrementally later if we want. The new board has enough issues to take care of. For now, I'd rather investigate those than YAML ;)
[unhandled content-type:application/pgp-signature]
| |