lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] soc: samsung: Add missing of_node_put in exynos-pmu.c
    Date
    In exynos_get_pmu_regmap(), of_find_matching_node() will return a
    node pointer with refcount incremented. We should use of_node_put()
    for that node pointer. We need a similar code logic in the function
    syscon_regmap_lookup_by_compatible().

    Signed-off-by: heliang <windhl@126.com>
    ---
    drivers/soc/samsung/exynos-pmu.c | 10 +++++++---
    1 file changed, 7 insertions(+), 3 deletions(-)

    diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
    index 732c86ce2be8..a44862c405a4 100644
    --- a/drivers/soc/samsung/exynos-pmu.c
    +++ b/drivers/soc/samsung/exynos-pmu.c
    @@ -108,9 +108,13 @@ struct regmap *exynos_get_pmu_regmap(void)
    {
    struct device_node *np = of_find_matching_node(NULL,
    exynos_pmu_of_device_ids);
    - if (np)
    - return syscon_node_to_regmap(np);
    - return ERR_PTR(-ENODEV);
    + struct regmap *regmap;
    + if (!np)
    + return ERR_PTR(-ENODEV);
    +
    + regmap = syscon_node_to_regmap(np);
    + of_node_put(np);
    + return regmap;
    }
    EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap);

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-15 10:57    [W:2.402 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site