Messages in this thread | | | Date | Thu, 16 Jun 2022 02:16:15 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv4 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page |
| |
On Wed, Jun 15, 2022 at 03:36:02PM -0700, Dave Hansen wrote: > On 6/15/22 15:32, Kirill A. Shutemov wrote: > >>> /* > >>> * Reject EPT violation #VEs that split pages. > >>> * > >>> * MMIO accesses are supposed to be naturally aligned and therefore > >>> * never cross page boundaries. Seeing split page accesses indicates > >>> * a bug or a load_unaligned_zeropad() that stepped into an MMIO page. > >>> * > >>> * load_unaligned_zeropad() will recover using exception fixups. > >>> */ > > Looks good, thanks. > > I've got that snippet and a few other things staged here: > > > https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=testme > > Could you take a quick look through before I push them somewhere for real?
Looks good to me. Could you fold in the off-by-one fix?
-- Kirill A. Shutemov
| |