lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v12 05/13] PCI: imx6: Factor out ref clock disable to match enable
    Date
    From: Bjorn Helgaas <bhelgaas@google.com>

    The PCIe ref clocks are specific to different variants. The enables are
    already split out into imx6_pcie_enable_ref_clk(), but the disables were
    combined with the more generic bus/phy/pcie clock disables in
    imx6_pcie_clk_disable().

    Split out the variant-specific disables into imx6_pcie_disable_ref_clk() to
    match imx6_pcie_enable_ref_clk().

    No functional change intended.

    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    ---
    drivers/pci/controller/dwc/pci-imx6.c | 16 ++++++++++------
    1 file changed, 10 insertions(+), 6 deletions(-)

    diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
    index 38f208eea2d7..f458461880dc 100644
    --- a/drivers/pci/controller/dwc/pci-imx6.c
    +++ b/drivers/pci/controller/dwc/pci-imx6.c
    @@ -580,12 +580,8 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie)
    return ret;
    }

    -static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)
    +static void imx6_pcie_disable_ref_clk(struct imx6_pcie *imx6_pcie)
    {
    - clk_disable_unprepare(imx6_pcie->pcie);
    - clk_disable_unprepare(imx6_pcie->pcie_phy);
    - clk_disable_unprepare(imx6_pcie->pcie_bus);
    -
    switch (imx6_pcie->drvdata->variant) {
    case IMX6SX:
    clk_disable_unprepare(imx6_pcie->pcie_inbound_axi);
    @@ -595,8 +591,8 @@ static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)
    IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
    IMX7D_GPR12_PCIE_PHY_REFCLK_SEL);
    break;
    - case IMX8MQ:
    case IMX8MM:
    + case IMX8MQ:
    clk_disable_unprepare(imx6_pcie->pcie_aux);
    break;
    default:
    @@ -604,6 +600,14 @@ static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)
    }
    }

    +static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)
    +{
    + clk_disable_unprepare(imx6_pcie->pcie);
    + clk_disable_unprepare(imx6_pcie->pcie_phy);
    + clk_disable_unprepare(imx6_pcie->pcie_bus);
    + imx6_pcie_disable_ref_clk(imx6_pcie);
    +}
    +
    static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)
    {
    struct device *dev = imx6_pcie->pci->dev;
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-16 01:18    [W:4.497 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site