Messages in this thread | | | Date | Wed, 15 Jun 2022 18:03:57 -0400 | From | William Breathitt Gray <> | Subject | Re: [PATCH v3] isa: put_device after failing to device_register |
| |
On Wed, Jun 15, 2022 at 11:15:58PM +0800, Zhi Song wrote: > device_register() is used to register a device with the system. > We need to call put_device() to give up the reference initialized > in device_register() when it returns an error and this will clean > up correctly. > > Fixes: a5117ba7da37 ("Driver model: add ISA bus") > Signed-off-by: Zhi Song <zhi.song@bytedance.com>
Acked-by: William Breathitt Gray <william.gray@linaro.org>
> --- > V1 -> V2: Fix up the changelog text correct. > V2 -> V3: Add a fixes tag line specifying the commit where this bug was > introduced. > --- > drivers/base/isa.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/isa.c b/drivers/base/isa.c > index 55e3ee2da98f..cf88f3d77b7d 100644 > --- a/drivers/base/isa.c > +++ b/drivers/base/isa.c > @@ -173,8 +173,10 @@ static int __init isa_bus_init(void) > error = bus_register(&isa_bus_type); > if (!error) { > error = device_register(&isa_bus); > - if (error) > + if (error) { > + put_device(&isa_bus); > bus_unregister(&isa_bus_type); > + } > } > return error; > } > -- > 2.30.2 > [unhandled content-type:application/pgp-signature] | |