lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH v4 4/4] PM / devfreq: Mute warning on governor PROBE_DEFER
    From
    On 22. 6. 15. 08:09, Christian 'Ansuel' Marangi wrote:
    > Don't print warning when a governor PROBE_DEFER as it's not a real
    > GOV_START fail.
    >
    > Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
    > Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
    > ---
    > drivers/devfreq/devfreq.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
    > index 2e2b3b414d67..6a39638ed064 100644
    > --- a/drivers/devfreq/devfreq.c
    > +++ b/drivers/devfreq/devfreq.c
    > @@ -931,8 +931,9 @@ struct devfreq *devfreq_add_device(struct device *dev,
    > err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
    > NULL);
    > if (err) {
    > - dev_err(dev, "%s: Unable to start governor for the device\n",
    > - __func__);
    > + dev_err_probe(dev, err,
    > + "%s: Unable to start governor for the device\n",
    > + __func__);
    > goto err_init;
    > }
    > create_sysfs_files(devfreq, devfreq->governor);


    In order to keep the left-align with above error log
    when try_then_request_governor() is failed,
    I recommend to use the tab without space indentation as following:

    If you have no objection, I'll merge this change.

    diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
    index 01474daf4548..80a1235ef8fb 100644
    --- a/drivers/devfreq/devfreq.c
    +++ b/drivers/devfreq/devfreq.c
    @@ -932,8 +932,9 @@ struct devfreq *devfreq_add_device(struct device *dev,
    err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
    NULL);
    if (err) {
    - dev_err(dev, "%s: Unable to start governor for the device\n",
    - __func__);
    + dev_err_probe(dev, err,
    + "%s: Unable to start governor for the device\n",
    + __func__);
    goto err_init;
    }
    create_sysfs_files(devfreq, devfreq->governor);




    --
    Best Regards,
    Samsung Electronics
    Chanwoo Choi

    \
     
     \ /
      Last update: 2022-06-15 08:58    [W:2.181 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site