Messages in this thread | | | Date | Wed, 15 Jun 2022 12:41:05 -0600 | From | Keith Busch <> | Subject | Re: [PATCH] nvme: Report model,sn,fw,pci device information during init |
| |
On Wed, Jun 15, 2022 at 08:02:13PM +0200, Erwan Velu wrote: > SCSI-based device get their identify properties being printed when initialized like : > > [ 1.245357] scsi 0:0:0:0: Direct-Access ATA HGST HTE721010A9 A3M0 PQ: 0 ANSI: 5 > > When initializing nvme devices, no identification message is reported > making difficult to identify them during the boot process. If the system > crashes during boot process or if the init phase fail, it could be very diffcult > to identify the faulty disk. > > This patch reports model, serial, firmware version and pci information > as soon as possible making this early identifying task possible. > > Reporting the serial has the interest of being able to ensure which > physical drive is concerned if a hardware replacement is required and > host features the exact same drive multiple times. > > A typical output looks like: > [ 0.383353] nvme nvme0: pci function 0000:00:03.0 > [ 0.418184] nvme nvme0: MODEL:QEMU NVMe Ctrl SN:deadbeef FW:1.0 PCI_ID:1b36:1af4 > [ 0.422020] nvme nvme0: 1/0/0 default/read/poll queues
The PCI_ID: print is misleading. That format usually indicates VID:DID, but you're printing VID:SSVID.
This is also very similar to the recently introduced nvme_print_device_info(), but that one removes the annoying trailing spaces if they exist. I guess if we're going this direction, just use that print, but change it from dev_err to dev_info, and remove the call on global id collision detection.
| |