Messages in this thread | | | From | Kechen Lu <> | Subject | RE: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU cap KVM_CAP_X86_DISABLE_EXITS | Date | Wed, 15 Jun 2022 18:21:53 +0000 |
| |
Hi Chao,
> -----Original Message----- > From: Chao Gao <chao.gao@intel.com> > Sent: Tuesday, June 14, 2022 8:14 PM > To: Kechen Lu <kechenl@nvidia.com> > Cc: kvm@vger.kernel.org; pbonzini@redhat.com; seanjc@google.com; > vkuznets@redhat.com; Somdutta Roy <somduttar@nvidia.com>; linux- > kernel@vger.kernel.org > Subject: Re: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU > cap KVM_CAP_X86_DISABLE_EXITS > > External email: Use caution opening links or attachments > > > >+/* Set debug control for trapped instruction exiting to userspace */ > >+static void vcpu_set_debug_exit_userspace(struct kvm_vm *vm, int > vcpuid, > >+ struct kvm_guest_debug *debug) { > > The debug argument looks pointless. Probably you can remove it.
Makes sense. Thanks for pointing out. Will remove it.
BR, Kechen
> > >+ memset(debug, 0, sizeof(*debug)); > >+ debug->control = KVM_GUESTDBG_ENABLE | > KVM_GUESTDBG_EXIT_USERSPACE; > >+ vcpu_set_guest_debug(vm, VCPU_ID_1, debug); }
| |