lkml.org 
[lkml]   [2022]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 0/3] Add support for the TLC5925
On Tue, Jun 14, 2022 at 5:42 PM Jean-Jacques Hiblot
<jjhiblot@traphandler.com> wrote:
>
> This series adds the support for the TLC5925 LED controller.
> This LED controller is driven through SPI. There is little internal logic
> and it can be thought of as a deserializer + latches.
> The TLC5925 itself drives up to 16 LEDs, but multiple TLC5925s can be
> chained to drive more.
>
> The first patch describes the dt bindings.
> The second patch implements most of the driver and supports only
> synchronous brightness setting (brightness_set_blocking).
> The last patch implements the non-blocking version (brightness_set).

Thanks!

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
for the entire series.

You may (if v6 is needed) to keep headers ordered (like gpio/consumer
as G and workqueue as W in alphabet).

> changes v4->v5:
> * add the headers that the code is a direct user of
> * replace dev_err() with dev_err_probe() in ->probe()
> * comestic changes (spaces, alignment and blank lines)
>
> changes v3->v4:
> * add missing MODULE_DEVICE_TABLE(of, ...)
> * use dev_err_probe() to avoid spamming the log in case of deferred probe
> * use bitmap ops instead of direct memory access + lock
> * sort headers and a few other cosmetic changes.
>
> changes v2->v3:
> * fixed the yaml description of the bindings (now passes dt_binding_check)
> * renamed shit-register-length into ti,shift-register-length and specify
> its type
>
> changes v1->v2:
> * renamed property shift_register_length into shift-register-length
> * add a SPI MODULE_DEVICE_TABLE structure
> * fixed the yaml description of the bindings (now passes dt_binding_check)
>
> Jean-Jacques Hiblot (3):
> dt-bindings: leds: Add bindings for the TLC5925 controller
> leds: Add driver for the TLC5925 LED controller
> leds: tlc5925: Add support for non blocking operations
>
> .../devicetree/bindings/leds/ti,tlc5925.yaml | 107 +++++++++++
> drivers/leds/Kconfig | 6 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-tlc5925.c | 181 ++++++++++++++++++
> 4 files changed, 295 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/ti,tlc5925.yaml
> create mode 100644 drivers/leds/leds-tlc5925.c
>
> --
> 2.25.1
>


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-06-14 18:01    [W:0.136 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site