lkml.org 
[lkml]   [2022]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index
From
Am 14.06.22 um 01:34 schrieb Florian Fainelli:
> On 6/13/22 05:46, Ariel D'Alessandro wrote:
>> Hi Peter,
>>
>> On 6/12/22 17:38, Peter Robinson wrote:
>>> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
>>> <ariel.dalessandro@collabora.com> wrote:
>>>>
>>>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>>>> change depending on the probe order of the MMC drivers.
>>>
>>> Is  the bcm2711-rpi.dtsi a better place for it given there's other
>>> aliases there and it will be consistent across variations?
>>
>> Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
>>
>> The other board what will be affected by this alias is the Raspberry Pi
>> Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
>> alias makes sense, to have that as the first mmc device.
>>
>> Maybe we can add the alias as follows?
>>
>>      mmc0 = &emmc2;  /* mmcblk0 for eMMC/SD */
>
> You have made a typo on the bcm-kernel-feedback-list meaning that this
> won't reach the patchwork instance I use to manage and apply patches,
> can you please fix that up for your v2? Thanks!
Not just the bcm-kernel-feedback-list is affected, also the address of
Krzysztof, Rob and Nicolas has a g prepended.

\
 
 \ /
  Last update: 2022-06-14 08:36    [W:0.058 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site