Messages in this thread | | | Date | Tue, 14 Jun 2022 16:37:56 +0200 | From | Greg KH <> | Subject | Re: [PATCH] node: put_device after failing to device_register |
| |
On Tue, Jun 14, 2022 at 10:30:07PM +0800, Zhi Song wrote: > device_register() is used to register a device with the system. > > We cannot directly free dev after calling this function, > even if it returns an error.
the device is not being freed, why say this?
And you do have a full 72 columns to use :)
> > We should use put_device() to give up the reference > initialized in this function instead.
There is no "instead" happening here. The patch looks correct, but this changelog text does not. Please fix up.
thanks,
greg k-h
| |