Messages in this thread | | | Subject | Re: [PATCH] ethtool: Fix and simplify ethtool_convert_link_mode_to_legacy_u32() | From | patchwork-bot+netdevbpf@kernel ... | Date | Tue, 14 Jun 2022 06:30:13 +0000 |
| |
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>:
On Thu, 9 Jun 2022 15:49:01 +0200 you wrote: > Fix the implementation of ethtool_convert_link_mode_to_legacy_u32(), which > is supposed to return false if src has bits higher than 31 set. The current > implementation uses the complement of bitmap_fill(ext, 32) to test high > bits of src, which is wrong as bitmap_fill() fills _with long granularity_, > and sizeof(long) can be > 4. No users of this function currently check the > return value, so the bug was dormant. > > [...]
Here is the summary with links: - ethtool: Fix and simplify ethtool_convert_link_mode_to_legacy_u32() https://git.kernel.org/netdev/net-next/c/19d62f5eeaa0
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |