lkml.org 
[lkml]   [2022]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init()
Date
The of_node_put() need be called in error path in logicvc_layers_init().

Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index bae1c7f99569..00a37563a6dc 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -610,8 +610,11 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
}

ret = logicvc_layer_init(logicvc, layer_node, index);
- if (ret)
+ if (ret) {
+ of_node_put(layer_node);
+ of_node_put(layers_node);
goto error;
+ }

of_node_put(layer_node);
}
--
2.25.1
\
 
 \ /
  Last update: 2022-06-14 13:12    [W:0.035 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site