Messages in this thread | | | Date | Mon, 13 Jun 2022 22:49:17 -0700 | From | Jakub Kicinski <> | Subject | Re: [net-next PATCH 2/2] net: ethernet: stmmac: reset force speed bit for ipq806x |
| |
On Thu, 9 Jun 2022 02:28:31 +0200 Christian 'Ansuel' Marangi wrote: > + dn = of_get_child_by_name(pdev->dev.of_node, "fixed-link"); > + ret = of_property_read_u32(dn, "speed", &link_speed); > + if (ret) { > + dev_err(dev, "found fixed-link node with no speed"); > + return ret;
Doesn't this return potentially leak the reference on dn? You move the of_node_put() right before the if (ret) {
> + } > + > + of_node_put(dn);
| |