Messages in this thread | | | Date | Tue, 14 Jun 2022 11:33:10 +0100 | Subject | Re: [PATCH] mm: Remove unwanted initialization in vmemmap_populate_compound_pages() | From | Joao Martins <> |
| |
On 6/12/22 19:23, Gautam Menghani wrote: > Remove unwanted initialization for the variable 'next'. This fixes the > clang scan warning: Value stored to 'next' during its initialization is > never read [deadcode.DeadStores] > > Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
Ugh, thanks for catching that:
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
> --- > mm/sparse-vmemmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > index f4fa61dbbee3..3008aa7859e0 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -737,7 +737,7 @@ static int __meminit vmemmap_populate_compound_pages(unsigned long start_pfn, > > size = min(end - start, pgmap_vmemmap_nr(pgmap) * sizeof(struct page)); > for (addr = start; addr < end; addr += size) { > - unsigned long next = addr, last = addr + size; > + unsigned long next, last = addr + size; > > /* Populate the head page vmemmap page */ > pte = vmemmap_populate_address(addr, node, NULL, NULL);
| |