Messages in this thread | | | Date | Tue, 14 Jun 2022 17:20:23 +1000 | Subject | Re: [PATCH v5 1/4] kernfs: make ->attr.open RCU protected. | From | Imran Khan <> |
| |
Hello Tejun,
On 14/6/22 1:19 pm, Tejun Heo wrote: > On Tue, Jun 14, 2022 at 12:08:37PM +1000, Imran Khan wrote: >> +static struct kernfs_open_node * [...] > > Hahahaha didn't know they'd be taking two different arguments. Sorry about > the many iterations but it'd probably be better to have two different > versions for the two argument types. Other than that, looks fine to me. >
No problem. I have made the changes in v6 (at [1]) to make use of 2 helpers based on the arguments.
Thanks -- Imran
[1]: https://lore.kernel.org/lkml/20220614070346.810168-1-imran.f.khan@oracle.com/
| |