Messages in this thread Patch in this message | | | From | Yang Yingliang <> | Subject | [PATCH -next] powerpc/fsl_rio: add missing of_node_put() in fsl_rio_setup() | Date | Wed, 15 Jun 2022 11:21:37 +0800 |
| |
of_find_compatible_node() and for_each_child_of_node() will increase the refcount of 'np', so add of_node_put() after using it to avoid refcount leak.
Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- arch/powerpc/sysdev/fsl_rio.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c index 1bfc9afa8a1a..97bbecb259dc 100644 --- a/arch/powerpc/sysdev/fsl_rio.c +++ b/arch/powerpc/sysdev/fsl_rio.c @@ -542,9 +542,11 @@ int fsl_rio_setup(struct platform_device *dev) if (!dt_range) { pr_err("%pOF: unable to find 'reg' property\n", np); + of_node_put(np); rc = -ENOMEM; goto err_pw; } + of_node_put(np); range_start = of_read_number(dt_range, aw); dbell->dbell_regs = (struct rio_dbell_regs *)(rmu_regs_win + (u32)range_start); @@ -570,9 +572,11 @@ int fsl_rio_setup(struct platform_device *dev) if (!dt_range) { pr_err("%pOF: unable to find 'reg' property\n", np); + of_node_put(np); rc = -ENOMEM; goto err; } + of_node_put(np); range_start = of_read_number(dt_range, aw); pw->pw_regs = (struct rio_pw_regs *)(rmu_regs_win + (u32)range_start); @@ -582,6 +586,7 @@ int fsl_rio_setup(struct platform_device *dev) if (!port_index) { dev_err(&dev->dev, "Can't get %pOF property 'cell-index'\n", np); + of_node_put(np); continue; } @@ -589,6 +594,7 @@ int fsl_rio_setup(struct platform_device *dev) if (!dt_range) { dev_err(&dev->dev, "Can't get %pOF property 'ranges'\n", np); + of_node_put(np); continue; } @@ -611,6 +617,7 @@ int fsl_rio_setup(struct platform_device *dev) dev_info(&dev->dev, "%pOF: LAW start 0x%016llx, size 0x%016llx.\n", np, range_start, range_size); + of_node_put(np); port = kzalloc(sizeof(struct rio_mport), GFP_KERNEL); if (!port) -- 2.25.1
| |