Messages in this thread | | | Date | Tue, 14 Jun 2022 09:08:41 +0200 | Subject | Re: [PATCH v3 0/3] KUnit tests for drm_format_helper | From | Thomas Zimmermann <> |
| |
Hi Jose,
for the whole patchset:
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
One small detail on licensing: drm_format_helper.c is licensed under GPL2 or MIT. Maybe consider adding 'or MIT' to drm_format_helper_test.c as well.
Best regards Thomas
Am 13.06.22 um 19:17 schrieb José Expósito: > Hello everyone, > > Here is the v3 of the series, including the documentation, previously > sent as a standalone patch [1], and changes suggested during review. > > Thanks a lot, > José Expósito > > RFC -> v1: https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposito89@gmail.com/T/ > > - Add .kunitconfig (Maxime Ripard) > - Fix memory leak (Daniel Latypov) > - Make config option generic (Javier Martinez Canillas): > DRM_FORMAR_HELPER_TEST -> DRM_KUNIT_TEST > - Remove DISABLE_STRUCTLEAK_PLUGIN (Daniel Latypov) > > v1 -> v2: https://lore.kernel.org/dri-devel/20220606095516.938934-1-jose.exposito89@gmail.com/T/ > > Thomas Zimmermann: > - Add DRM_RECT_INIT() macro > - Move tests to drivers/gpu/drm/kunit > - Improve test documentation > > v2 -> v3: https://lore.kernel.org/dri-devel/20220612161248.271590-1-jose.exposito89@gmail.com/T/ > > - Use designated initializer in DRM_RECT_INIT (Jani Nikula) > - Simplify the "conversion_buf_size" helper > > [1] https://lore.kernel.org/dri-devel/20220606180940.43371-1-jose.exposito89@gmail.com/T/ > > José Expósito (3): > drm/rect: Add DRM_RECT_INIT() macro > drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() > drm/doc: Add KUnit documentation > > Documentation/gpu/drm-internals.rst | 32 ++++ > drivers/gpu/drm/Kconfig | 16 ++ > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/kunit/.kunitconfig | 3 + > drivers/gpu/drm/kunit/Makefile | 3 + > .../gpu/drm/kunit/drm_format_helper_test.c | 160 ++++++++++++++++++ > include/drm/drm_rect.h | 16 ++ > 7 files changed, 231 insertions(+) > create mode 100644 drivers/gpu/drm/kunit/.kunitconfig > create mode 100644 drivers/gpu/drm/kunit/Makefile > create mode 100644 drivers/gpu/drm/kunit/drm_format_helper_test.c >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [unhandled content-type:application/pgp-signature] | |